Skip to content

chore: upgrae hermetic_launcher to v0.0.13#1273

Merged
jbedard merged 1 commit into
mainfrom
hermetic_launcher-12
Jul 24, 2026
Merged

chore: upgrae hermetic_launcher to v0.0.13#1273
jbedard merged 1 commit into
mainfrom
hermetic_launcher-12

Conversation

@jbedard

@jbedard jbedard commented Jul 7, 2026

Copy link
Copy Markdown
Member

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 7, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@jbedard
jbedard requested review from acozzette and xangcastle July 7, 2026 22:22
@aspect-workflows

aspect-workflows Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Fri Jul 24 04:30:49 UTC 2026

✅ 40 successful tasks

  • ✅ buildifier · ⏱ 17.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle · ⏱ 16.3s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ test-e2e-bazel-8 [test] · ⏱ 4m 8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (238/238 passed)
  • ✅ test-e2e-bazel-9 [test] · ⏱ 4m 56s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (232/232 passed)
  • ✅ test-e2e-interpreter-build-config-bazel-8 [test] · ⏱ 21.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-interpreter-build-config-bazel-9 [test] · ⏱ 48.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-interpreter-input-validation-bazel-8 [test] · ⏱ 22.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-interpreter-input-validation-bazel-9 [test] · ⏱ 30.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-interpreter-runtime-metadata-bazel-8 [test] · ⏱ 21.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (2/2 passed)
  • ✅ test-e2e-interpreter-runtime-metadata-bazel-9 [test] · ⏱ 52.4s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (2/2 passed)
  • ✅ test-e2e-interpreter-toolchain-settings-bazel-8 [test] · ⏱ 18.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-interpreter-toolchain-settings-bazel-9 [test] · ⏱ 58.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-rules-proto-grpc-python-bazel-8 [test] · ⏱ 1m 48s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-rules-proto-grpc-python-bazel-9 [test] · ⏱ 1m 8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-e2e-rules-python-interop-bazel-8 [test] · ⏱ 32.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (7/7 passed)
  • ✅ test-e2e-rules-python-interop-bazel-9 [test] · ⏱ 41s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (7/7 passed)
  • ✅ test-examples-debugger-bazel-8 [test] · ⏱ 26.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-examples-debugger-bazel-9 [test] · ⏱ 1m 11s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-dev_deps-bazel-8 [test] · ⏱ 27.7s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-examples-dev_deps-bazel-9 [test] · ⏱ 1m · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-django-bazel-8 [test] · ⏱ 24.7s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-examples-django-bazel-9 [test] · ⏱ 56.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-multi_version-bazel-8 [test] · ⏱ 25.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (2/2 passed)
  • ✅ test-examples-multi_version-bazel-9 [test] · ⏱ 57.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (2/2 passed)
  • ✅ test-examples-protobuf-bazel-8 [test] · ⏱ 1m 15s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-protobuf-bazel-9 [test] · ⏱ 1m 36s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-py_binary-bazel-8 [test] · ⏱ 22.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-examples-py_binary-bazel-9 [test] · ⏱ 1m · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-py_pex_binary-bazel-8 [test] · ⏱ 26.7s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-examples-py_pex_binary-bazel-9 [test] · ⏱ 36.4s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-py_venv-bazel-8 [test] · ⏱ 20.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (3/3 passed)
  • ✅ test-examples-py_venv-bazel-9 [test] · ⏱ 45s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (3/3 passed)
  • ✅ test-examples-pytest-bazel-8 [test] · ⏱ 40.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (11/11 passed)
  • ✅ test-examples-pytest-bazel-9 [test] · ⏱ 1m 4s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (11/11 passed)
  • ✅ test-examples-uv_pip_compile-bazel-8 [test] · ⏱ 24.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-uv_pip_compile-bazel-9 [test] · ⏱ 48s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-virtual_deps-bazel-8 [test] · ⏱ 31.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-examples-virtual_deps-bazel-9 [test] · ⏱ 1m 25s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)
  • ✅ test-root-bazel-8 [test] · ⏱ 2m 49s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (269/269 passed)
  • ✅ test-root-bazel-9 [test] · ⏱ 2m 28s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (268/268 passed)

⏱ Last updated Fri Jul 24 04:35:41 UTC 2026 · 📊 GitHub API quota 528/15,000 (4% used, resets in 40m)
🚀 Powered by Aspect CLI (v2026.28.2)  |  Aspect Build · X · LinkedIn · YouTube

@jbedard
jbedard marked this pull request as draft July 7, 2026 22:26
@jbedard

jbedard commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

blocked waiting for BCR for now

@jbedard
jbedard force-pushed the hermetic_launcher-12 branch from cc5430d to 541ba9d Compare July 16, 2026 05:19
@jjudd

jjudd commented Jul 24, 2026

Copy link
Copy Markdown

In case it's at all helpful: hermetic-launcher 0.0.13 is now available on BCR https://registry.bazel.build/modules/hermetic_launcher and I believe it has a fix rules_py is interested for running py_binary: hermeticbuild/hermetic-launcher#59

@jbedard
jbedard force-pushed the hermetic_launcher-12 branch 2 times, most recently from c783711 to d69c4b1 Compare July 24, 2026 02:14
@jbedard jbedard changed the title chore: upgrae hermetic_launcher to v0.0.12 chore: upgrae hermetic_launcher to v0.0.13 Jul 24, 2026
@jbedard
jbedard marked this pull request as ready for review July 24, 2026 02:14
@jbedard

jbedard commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

Thanks for the ping @jjudd 👍

@jbedard
jbedard enabled auto-merge (squash) July 24, 2026 02:14
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 24, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d69c4b1fbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread MODULE.bazel
@github-actions

github-actions Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

py_binary startup benchmark

Version Mean (ms) Median (ms) ± stddev vs BCR vs main Build (s)
BCR 1.11.7 (baseline) 182.056 180.992 ±7.648 — — 32.26
HEAD main 60.497 60.112 ±2.354 -66.8% — 11.03
This PR 59.440 58.925 ±2.080 -67.4% -1.7% 8.71

Measured with hyperfine --warmup 5 --runs 50 on Linux
Gate: PR vs HEAD main (threshold: 10%). BCR is shown only as a historical baseline.
Build time: cold bazel build //:bench with isolated output base, no disk cache.

sys.path quality

Version sys.path entries distinct site-packages roots duplicate realpaths
BCR 1.11.7 (baseline) 6 1 0
HEAD main 7 2 0
This PR 7 2 0

sys.path quality measured by bench_syspath inside the assembled venv. Duplicate realpaths indicate symlink redundancy; many distinct site-packages roots suggest an inefficient venv layout.

Bazel analysis benchmark

Version Mean (ms) Median (ms) ± stddev vs BCR vs main Packages Targets
BCR 2.0.0-alpha.4 (baseline) 10909.510 10845.429 ±209.760 — — 101 301
HEAD main 9422.731 9390.992 ±90.533 -13.6% — 101 301
This PR 9658.319 9643.622 ±157.390 -11.5% +2.5% 101 301

Measured with hyperfine --warmup 1 --runs 10 on Linux
Gate: PR vs HEAD main (threshold: 10%). BCR is shown only as a historical baseline.
Command: cold bazel build --nobuild //workspace/... with isolated output base, no disk cache.

Auxiliary metrics

Version Loaded packages Configured targets
BCR 2.0.0-alpha.4 (baseline) 101 301
HEAD main 101 301
This PR 101 301

@jbedard
jbedard force-pushed the hermetic_launcher-12 branch from d69c4b1 to 100ec83 Compare July 24, 2026 02:38
@jbedard
jbedard force-pushed the hermetic_launcher-12 branch from 100ec83 to 7c7ce38 Compare July 24, 2026 04:30
@jbedard
jbedard merged commit 4f736b5 into main Jul 24, 2026
87 checks passed
@jbedard
jbedard deleted the hermetic_launcher-12 branch July 24, 2026 04:38
@jbedard jbedard mentioned this pull request Jul 24, 2026
Merged
xangcastle pushed a commit that referenced this pull request Jul 24, 2026
@jbedard
test(launcher): guard runfiles source selection from the 0.0.13 upgra…
421da95 
…de (#1367)

Testing the issue that
#1273 fixed

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@xangcastle xangcastle xangcastle approved these changes
@acozzette acozzette Awaiting requested review from acozzette

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbedard @jjudd @xangcastle